Adjust timeout for auto detection. I forgot these devices would be slow because most of them are very old with much less speed than would be expected today.

tests/unit/test_hardware_speech_drivers.py

@@ -166,6 +166,9 @@ def test_auto_device_detection_prefers_probe_response(monkeypatch):
 
     def fake_select(readable, writable, exceptional, timeout):
         port = readable[0]
+        if timeout == 0:
+            return [], writable, exceptional
+        assert timeout == 3.5
         if port == 101 and writes.get(port) == b"\x01I":
             return readable, writable, exceptional
         return [], writable, exceptional
@@ -273,6 +276,70 @@ def test_auto_device_detection_fails_without_probe_response(
     assert speech_driver.device == "auto"
 
 
+def test_auto_device_detection_deduplicates_serial_by_id(monkeypatch):
+    opened_devices = []
+
+    def fake_glob(pattern):
+        if pattern == "/dev/serial/by-id/*":
+            return ["/dev/serial/by-id/modem0"]
+        if pattern == "/dev/ttyUSB*":
+            return ["/dev/ttyUSB0"]
+        return []
+
+    def fake_realpath(path):
+        if path in ("/dev/serial/by-id/modem0", "/dev/ttyUSB0"):
+            return "/dev/ttyUSB0"
+        return path
+
+    monkeypatch.setattr(
+        "fenrirscreenreader.speechDriver.hardwareSerialDriver.glob.glob",
+        fake_glob,
+    )
+    monkeypatch.setattr(
+        "fenrirscreenreader.speechDriver.hardwareSerialDriver.os.path.realpath",
+        fake_realpath,
+    )
+    monkeypatch.setattr(
+        "fenrirscreenreader.speechDriver.hardwareSerialDriver.os.open",
+        lambda device, flags: opened_devices.append(device)
+        or len(opened_devices),
+    )
+    monkeypatch.setattr(
+        "fenrirscreenreader.speechDriver.hardwareSerialDriver.os.close",
+        lambda port: None,
+    )
+    monkeypatch.setattr(
+        "fenrirscreenreader.speechDriver.hardwareSerialDriver.os.write",
+        lambda port, data: len(data),
+    )
+    monkeypatch.setattr(
+        "fenrirscreenreader.speechDriver.hardwareSerialDriver.select.select",
+        lambda readable, writable, exceptional, timeout: (
+            [],
+            writable,
+            exceptional,
+        ),
+    )
+    monkeypatch.setattr(
+        "fenrirscreenreader.speechDriver.hardwareSerialDriver.termios.tcgetattr",
+        lambda port: [0, 0, 0, 0, 0, 0, [0] * 32],
+    )
+    monkeypatch.setattr(
+        "fenrirscreenreader.speechDriver.hardwareSerialDriver.termios.tcsetattr",
+        lambda port, when, attrs: None,
+    )
+    monkeypatch.setattr(
+        "fenrirscreenreader.speechDriver.hardwareSerialDriver.tty.setraw",
+        lambda port: None,
+    )
+
+    speech_driver = litetalkDriver.driver()
+    with pytest.raises(RuntimeError, match="hardware speech device"):
+        speech_driver.initialize(build_environment("auto"))
+
+    assert opened_devices == ["/dev/serial/by-id/modem0"]
+
+
 def test_auto_device_detection_skips_termios_failures(monkeypatch):
     opened_ports = []
     closed_ports = []