storm/w3m
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,296 Commits 2 Branches 0 Tags
80642d1fe7ec6343825ef046408a82e45a5cdfcf
Commit Graph

2296 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rene Kita
80642d1fe7 Fix potential null dereference 2022-04-19 10:08:54 +02:00
Rene Kita
a0b3c1b467 Fix potential null dereference 2022-04-19 10:08:54 +02:00
Rene Kita
9eaf044c02 Check return value of Str... functions 
All these functions, StrmyUFgets, StrISgets, etc. can potentially return
NULL. Add a check for it.
 2022-04-19 10:08:54 +02:00
Rene Kita
d33a522936 Fix potential null pointer dereference 2022-04-19 10:08:54 +02:00
Rene Kita
1308f5efe5 Check for NULL before dereferencing the pointer 
In case of an error the whole frame is freed, break out of the loop to
return early.
 2022-04-19 10:08:54 +02:00
Rene Kita
9f5c311e45 Do not call fclose() on a NULL pointer 
The if clause is true if cache is NULL. man 3 fclose says:

  The  behaviour  of  fclose() is undefined if the stream parameter is an
  illegal pointer, or is a descriptor already passed to a previous  invo‐
  cation of fclose().

Check if cache is NULL before calling fclose().
 2022-04-19 10:08:54 +02:00
Rene Kita
1365cc1ecc Check for NULL before dereferencing a pointer 
l is part of the exit condition of the while loop. If we exit the loop
because l is NULL, we cannot dereference it.
 2022-04-19 10:08:54 +02:00
Rene Kita
6432709b80 Check for NULL before dereferencing a pointer 
get_auth_param() returns NULL in case of error.
 2022-04-19 10:08:54 +02:00
Rene Kita
22d1fb47ac Remove null pointer dereference 
This if is only true if both strchr return NULL, making sure that *q is
a NULL dereference.

The intention was to remove trailing '>' (or '\t') from the message-id
(p) for add_news_message().

Adjust the condition.
 2022-04-19 10:03:13 +02:00
Tatsuya Kinoshita
fa6da6a0fa Update ChangeLog 2022-04-15 21:20:11 +09:00
Tatsuya Kinoshita
238b77f0fa Allow building without terminal library 
This reverts commit 0d3416e0c2.
cf. https://github.com/tats/w3m/pull/221
Bug-Chromium: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46629
 2022-04-15 21:07:40 +09:00
Tatsuya Kinoshita
6338651e22 Allow building without Perl 
This reverts commit a0c8de3f3f.
cf. https://github.com/tats/w3m/pull/221
 2022-04-15 21:07:30 +09:00
Tatsuya Kinoshita
15c77e3687 Do not reject FreeBSD framebuffer 
This reverts commit cb3118b389.
cf. https://github.com/tats/w3m/pull/221
 2022-04-15 21:07:02 +09:00
Tatsuya Kinoshita
006871f44c Update ChangeLog 2022-04-10 11:47:54 +09:00
Tatsuya Kinoshita
020f626a95 Remove unused encodeB declaration 2022-04-10 10:07:27 +09:00
Tatsuya Kinoshita
13dea10910 Remove unused MAX_WIDTH 2022-04-10 10:07:04 +09:00
Tatsuya Kinoshita
79dc67566a Prefer https for GNU URLs 2022-04-10 10:06:33 +09:00
Tatsuya Kinoshita
eb7ebb48ed Update ChangeLog 2022-04-09 19:38:24 +09:00
Tatsuya Kinoshita
ca9f5fc096 Merge pull request #222 from rkta/Wall 
Fix all reported warnings when -Wall is enabled and enable -Wall by default. While there, move OPTS to end of CFLAGS. This allows the user to override default options.
 2022-04-09 19:32:49 +09:00
Tatsuya Kinoshita
fecbe424c2 Update ChangeLog 2022-04-08 20:53:12 +09:00
Tatsuya Kinoshita
9d7d98c237 Merge pull request #221 from rkta/configure 
Add some missing checks to configure.
 2022-04-08 20:44:46 +09:00
Tatsuya Kinoshita
f80ccd42a6 Merge pull request #220 from rkta/posubst 
Do not swallow errors from GCC
 2022-04-08 20:40:07 +09:00
Tatsuya Kinoshita
ba3b7547a0 Update ChangeLog 2022-04-06 20:09:22 +09:00
Tatsuya Kinoshita
7ed4f7796c Adjust spacing in menu strings 
cf. https://github.com/tats/w3m/issues/225
 2022-04-06 20:08:00 +09:00
Tatsuya Kinoshita
79e8f2d608 Fix typo in menu strings 2022-04-06 20:07:39 +09:00
Tatsuya Kinoshita
f323f98b1a Update ChangeLog 2022-04-05 22:42:02 +09:00
Tatsuya Kinoshita
93b6fce6ca Merge branch 'bug/po-de' 2022-04-05 22:34:35 +09:00
Markus Hiereth
9e930f88d9 Updated German message catalogue 2022-04-05 22:30:29 +09:00
Tatsuya Kinoshita
9a8b0b11b7 Merge pull request #209 from sebras/master 
Add Swedish translation.
 2022-04-05 22:21:45 +09:00
Rene Kita
97af1e481f Do not swallow errors from GCC 
Without this patch posubst always exits with 0. This is a problem when
chaining commands.
 2022-02-20 11:25:15 +01:00
Rene Kita
d5817a26c7 Use strict and warnings in posubst 2022-02-20 11:25:15 +01:00
Rene Kita
cb3118b389 Check for linux/fb.h when configuring 2022-02-20 11:17:27 +01:00
Rene Kita
a0c8de3f3f Let configure fail if Perl is not in $PATH 2022-02-20 11:17:27 +01:00
Rene Kita
0d3416e0c2 Let configure fail if no terminal library is found 2022-02-20 11:17:26 +01:00
Rene Kita
72177529d2 Ignore autom4te cache directory 2022-02-20 11:17:26 +01:00
Rene Kita
5b33d9f239 Cast away a warning under OpenBSD 7.0 2022-02-20 11:14:54 +01:00
Rene Kita
bf40283a80 Enable -Wall by default 2022-02-20 11:14:54 +01:00
Rene Kita
0073ec6daf Use unsigned int for image size 
This removes a warning with -Wall.
 2022-02-20 11:14:54 +01:00
Rene Kita
cf2fd623fc Use cast to suppress warning 2022-02-20 11:14:54 +01:00
Rene Kita
d3ea4b33f1 Initialize struct before use 2022-02-20 11:14:54 +01:00
Rene Kita
c5c63a1a3d Fix a potential buffer overflow 
When compiling with -Wformat-overflow=2 GCC reports:
  note: 'sprintf' output between 16 and 35 bytes into a destination of size 32
 2022-02-20 11:14:54 +01:00
Rene Kita
cf7058b56c Let base64_encode() take a char * 
Throughout the whole code base only char * is passed, but a unsigned
char * is expected. This leads to several warnings.

Fix the interface and cast to unsigned char * internally to avoid any
changes to the behaviour.
 2022-02-20 11:14:54 +01:00
Rene Kita
561f27f833 Explicitly cast to unsigned when passing to MD5() 2022-02-20 11:14:54 +01:00
Rene Kita
b25abc595c Let strncpy write the null terminator 2022-02-20 11:14:53 +01:00
Rene Kita
0cd26b92cb Take the correct char type in growbuf_append() 
This change removes all warnings (-Wall) from this function.
 2022-02-20 11:14:53 +01:00
Rene Kita
ab22479fb3 Fix warning for unused variable w/o MENU_SELECT 2022-02-20 11:14:53 +01:00
Rene Kita
4901408ea5 Fix warning for unused variable without USE_M17N 2022-02-20 11:14:53 +01:00
Rene Kita
916104b7f2 Remove unused variable 2022-02-20 11:14:53 +01:00
Rene Kita
dad5cbe83b Use main(void) when not taking arguments 2022-02-20 11:14:53 +01:00
Rene Kita
84f724a590 Use standard conforming main() definition 2022-02-20 11:14:53 +01:00