Fixed 2 speech-dispatcher bugs. First, multiword voice names were not available. Next, when the module changed the old voice name was carried in causing some modules to fail.

tests/unit/test_progress_detector.py

@@ -238,3 +238,55 @@ def test_progress_detector_ignores_generic_key_value_text():
 
     command.play_activity_beep.assert_not_called()
     command.play_progress_tone.assert_not_called()
+
+
+@pytest.mark.unit
+def test_progress_detector_beeps_for_pacman_total_in_multiline_delta():
+    progress_module = _load_progress_module()
+    command = progress_module.command()
+    total_line = (
+        "Total (  3/749)                                            "
+        "830.7 MiB  4.70 MiB/s 04:05 "
+        "[#################################################"
+        "-----------------------------------------------------------------------]  41%"
+    )
+    sample = (
+        "package-one  125.0 MiB  2.10 MiB/s 00:12 "
+        "[####################--------------------]  50%\n"
+        + total_line
+    )
+    command.env = {
+        "commandBuffer": {
+            "progress_monitoring": True,
+            "lastProgressValue": -1,
+            "lastProgressTime": 0,
+        },
+        "runtime": {
+            "DebugManager": Mock(write_debug_out=Mock()),
+            "ScreenManager": Mock(is_screen_change=Mock(return_value=False)),
+            "CursorManager": Mock(is_cursor_vertical_move=Mock(return_value=False)),
+        },
+        "screen": {
+            "new_delta": sample,
+            "new_delta_is_typing": False,
+            "new_content_text": sample,
+            "old_cursor": {"x": 0, "y": 0},
+            "new_cursor": {"x": 0, "y": 0},
+        },
+    }
+    command.play_progress_tone = Mock()
+
+    command.run()
+
+    command.play_progress_tone.assert_called_once_with(41.0)
+    assert command.env["commandBuffer"]["lastProgressValue"] == 41.0
+
+
+@pytest.mark.unit
+def test_explicit_progress_delta_ignores_percentage_in_bracketed_prose():
+    progress_module = _load_progress_module()
+    command = progress_module.command()
+
+    assert not command.is_explicit_progress_delta(
+        "Release notes [issue #749] are 41% complete"
+    )

tests/unit/test_speechd_voice_selection.py

@@ -0,0 +1,90 @@
+from types import SimpleNamespace
+from unittest.mock import Mock
+
+from fenrirscreenreader.commands.commands import voice_browser
+from fenrirscreenreader.commands.commands import voice_browser_safe
+from fenrirscreenreader.core import dynamicVoiceMenu
+from fenrirscreenreader.core.quickMenuManager import SpeechHelperMixin
+from fenrirscreenreader.utils.speechd_utils import get_synthesis_voice_name
+
+
+VOICE_LIST = (
+    "                     NAME                 LANGUAGE                  VARIANT\n"
+    "             Perfect Paul                    en-US                     none\n"
+    "                  Big Bob                    en-US                     none\n"
+)
+
+
+def completed_voice_list():
+    return SimpleNamespace(returncode=0, stdout=VOICE_LIST)
+
+
+def test_quick_menu_preserves_multiword_synthesis_voice_names(monkeypatch):
+    monkeypatch.setattr(
+        "fenrirscreenreader.core.quickMenuManager.subprocess.run",
+        Mock(return_value=completed_voice_list()),
+    )
+    helper = SpeechHelperMixin()
+    helper.env = {"runtime": {"DebugManager": Mock()}}
+
+    assert helper.get_module_voices("doubletalk") == [
+        "Perfect Paul",
+        "Big Bob",
+    ]
+
+
+def test_safe_voice_browser_preserves_multiword_synthesis_voice_names(
+    monkeypatch,
+):
+    monkeypatch.setattr(
+        voice_browser_safe.subprocess,
+        "run",
+        Mock(return_value=completed_voice_list()),
+    )
+    browser = voice_browser_safe.command()
+    browser.initialize({"runtime": {}})
+
+    assert browser.get_module_voices_with_timeout("doubletalk") == [
+        "Perfect Paul",
+        "Big Bob",
+    ]
+
+
+def test_interactive_voice_browser_preserves_multiword_synthesis_voice_names(
+    monkeypatch,
+):
+    monkeypatch.setattr(
+        voice_browser.subprocess,
+        "run",
+        Mock(return_value=completed_voice_list()),
+    )
+    browser = voice_browser.command()
+
+    assert browser.get_module_voices("doubletalk") == [
+        "Perfect Paul",
+        "Big Bob",
+    ]
+
+
+def test_dynamic_voice_menu_preserves_multiword_synthesis_voice_names(
+    monkeypatch,
+):
+    monkeypatch.setattr(
+        dynamicVoiceMenu.subprocess,
+        "run",
+        Mock(return_value=completed_voice_list()),
+    )
+
+    assert dynamicVoiceMenu.get_module_voices("doubletalk") == [
+        "Perfect Paul",
+        "Big Bob",
+    ]
+
+
+def test_espeak_voice_selection_keeps_language_and_variant_behavior():
+    voice = get_synthesis_voice_name(
+        "espeak-ng",
+        "English (America)+female3 en-US female3",
+    )
+
+    assert voice == "en-us+female3"