A Wine application can inherit a different D-Bus session address from the
running Cthulhu instance. The helper manager previously copied that address
from the application's environment, redirecting accessibility requests to
a bus where the supervising reader was unavailable. This left foobar2000
and its Preferences dialog silent despite working native control support.
Retain the reader's inherited DBUS_SESSION_BUS_ADDRESS when launching a
helper. Continue taking the application's display, runtime directory,
Wine prefix and loader so hooks still attach to the correct Wine session.
The manager remains responsible for helper startup and shutdown.
Extend the existing manager lifecycle regression to supply conflicting
application and reader bus addresses. Assert that the helper receives the
reader's bus, the application's display, the expected prefix and the
managed-helper marker, while retaining the shutdown checks. The regression
failed against the original implementation before the fix.
Validation:
- GOPROXY=off go test ./internal/wine -count=1
- GOPROXY=off go test -race ./internal/wine -count=1
- GOPROXY=off go vet ./internal/wine
- Built and installed the reader; configuration validation passed.
- After reload, both the default-prefix and Bard helpers used the reader's
bus. Foobar2000 Preferences opened on workspace 3 without settings changes.
- The user subsequently confirmed that the installed changes look good.
Thunderbird's message composer emits U+FFFC object replacement characters
when creating or removing paragraph objects. Treating these structural
updates as inserted or deleted text sent raw placeholders to speech,
including multi-character updates that bypass ordinary key-echo settings.
Remove object markers from insertion and deletion presentation while
preserving surrounding text. Normalize typing-echo payloads before deciding
the echo kind or applying character, word, and sentence echo policies.
Return no text or echo kind for updates containing only object markers.
Add regression cases for single and repeated markers, mixed marker/text
payloads, and ordinary text through both event presentation and typing echo.
Validation:
- go test ./... -count=1, with the local cache and dependency network disabled.
- Built the reader and the BrlAPI-tagged Braille helper.
- A disposable Thunderbird profile on a private X11 display and session bus
produced one marker-containing presentation before the fix and none after.
- Private Thunderbird checks preserved character, word, and line navigation
after typing several paragraphs.
- The user confirmed main-arrow reading worked with the restarted build.
The original silent-arrow failure was not reproduced in isolation. Restarting
restored reading in the user's session; this commit does not claim to fix
its underlying cause or change arrow-key handling. Physical Braille output
was not tested. Preserve the original and fresh diagnostic logs locally.
Resolve the parity-ledger conflict by retaining testing's updated LibreOffice entry and Steam progress entry alongside deedra's edit-label and Mozilla records.
Verified: go test ./... -count=1, go vet ./..., parity ledger validation, and whitespace checks. Native GUI and physical speech/Braille acceptance were not run.
Thunderbird HTML messages expose readable text on containers around embedded
objects. The browse cursor previously considered only text leaves, and native
document capture omitted heading/link character counts. This skipped message
content, headings and link text. A caret event following Tab could also replace
a complete link announcement with its first character.
Capture owned hypertext child identities and native placeholder offsets on the
GLib thread, releasing native interfaces before returning. Require every child
to occupy one embedded-object character so providers exposing duplicate text
through static descendants retain their ordinary traversal.
Traverse native text ranges before and after embedded children without changing
their offset domains. Preserve character, word, line and document-boundary
navigation; normalize native caret and Braille routing positions at adjacent
embedded links. Keep the Braille cursor on the correct fragment when a parent
contributes text more than once to an assembled line.
Ignore same-input link caret echoes after focus while retaining subsequent
arrow and selection feedback. Add regression tests, extend the private Firefox
fixture, and record behavior and remaining acceptance in the parity ledger.
Validation:
- Full Go test suite with count=1; focused app/atspi/review race checks.
- go vet ./...; reader and brlapi helper builds.
- Private Firefox baseline, mixed-parent offsets and tab navigation.
- Private Chromium fragments, named links, document navigation and selection.
- Parity ledger validation and whitespace checks.
The existing Firefox tab test intermittently timed out on both an untouched
HEAD copy and the changed tree; the final run passed. The unchanged
TestRunReachesSoundStopAfterEarlierServiceStopError also failed once during
startup cancellation and passed in subsequent full-suite and race runs.
Both installed binaries were verified and the reader reloaded in its original
desktop session. The maintainer confirmed readable message text and later
working links after an earlier intermittent omission. That omission remains
untraced; repeat live acceptance and physical Braille verification remain open.
Combine relation-only edit-label capture while retaining bounded text reads,
password-target exclusion, UTF-8 output limits and menu checkability capture.
Keep both label regression fixtures and the existing foreground test dispatch.
Preserve Wine helper diagnostics and recovery documentation, and retain the
current parity records alongside the incoming edit-label entry.
Validation:
- go test ./... -count=1 -timeout=180s
- go vet ./...
- CTHULHU_NATIVE_EDIT_LABELS=1 python3 tests/native_atspi.py
- Isolated TestNativeTextLabelRelations
- python3 tests/native_atspi.py
- Parity ledger validation: 65 rows
- Python syntax and staged diff checks
Native GTK table fixtures emitted ATK warnings; all assertions passed.
Live speech and physical Braille were not retested.
Irctest exposes its settings-field labels through AT-SPI LABELLED_BY
relations while leaving the fields' accessible names empty. Cthulhu
previously captured only the name, so focus speech announced the text
role and contents without Nickname, Username, or Real name.
Resolve direct label targets in the shared native snapshot capture for
unnamed text, entry, and password-text objects. Preserve explicit names,
combine multiple label targets in relation order, and use label/static
text only when a target has no accessible name. Bound relation scans,
target queries, and UTF-8 output; release all native references and avoid
reading password targets. No application-specific handling is required.
Add an isolated GTK fixture and native regression test exercising capture
and speech formatting for single labels, multiple labels, explicit names,
unlabelled fields, and labelled password fields without password contents.
Expose the probe through CTHULHU_NATIVE_EDIT_LABELS=1 in native_atspi.py.
Record verification and installed-reader acceptance in the parity ledger.
Validation:
- go test ./... -count=1
- CTHULHU_NATIVE_EDIT_LABELS=1 python3 tests/native_atspi.py
- go vet ./...
- Build the reader and the brlapi-tagged Braille helper.
- Validate configuration and testdata/parity-ledger.csv.
- Read-only live irctest capture includes all three settings-field labels
in formatted speech.
- Install both tested binaries and replace the reader in its original
desktop session; verify service ownership and installed build hashes.
- Maintainer confirms the installed reader now speaks the field labels.
The full suite passes outside the sandbox; its socket and process checks
require access unavailable inside the sandbox. Physical Braille acceptance
remains pending. Preserve cthulhu.log outside the commit.
Storm Dragon
lilmike
deedra
ak47