Add golangci-lint gate and fix its findings

Configure golangci-lint v2 for the whole tree (brlapi/duckdb build tags, curated linters, documented exclusions) and resolve what it reports: dead code, wrapped-error comparisons and %w wrapping, unclosed websocket handshake bodies, staticcheck SA/S items, ineffectual assignments, and explicit _ = discards for best-effort teardown errors. Document the gate in CONTRIBUTING and AGENTS.
This commit is contained in:
hjozwiak committed 2026-11-10 21:13:49 -05:00
1 parent b03cb8917d
commit 0459fb8e50
43 files changed
+166 -112

No files matched your search

+1 -1
View File
@@ -132,7 +132,7 @@ func (r *ReviewRegistry) Stop(ctx context.Context) error {
r.mutex.Unlock()
if conn != nil {
conn.RemoveSignal(signals)
conn.RemoveMatchSignal(dbus.WithMatchSender("org.freedesktop.DBus"), dbus.WithMatchInterface("org.freedesktop.DBus"), dbus.WithMatchMember("NameOwnerChanged"))
_ = conn.RemoveMatchSignal(dbus.WithMatchSender("org.freedesktop.DBus"), dbus.WithMatchInterface("org.freedesktop.DBus"), dbus.WithMatchMember("NameOwnerChanged"))
conn.Close()
}
if done != nil {