storm/w3m
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,405 Commits 2 Branches 0 Tags
c4862fd9c181dc359e983547972d7670c97fba51
Commit Graph

2405 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tatsuya Kinoshita
fa57b07002 Merge pull request #229 from rkta/null 
Fix all warnings when building with -Wnull-dereference
 2022-04-19 19:59:19 +09:00
Tatsuya Kinoshita
a582349397 Merge pull request #227 from rkta/linknumbers_at_eol 
Fix broken anchor with link number at EOL
 2022-04-19 19:58:55 +09:00
Rene Kita
a3b9887113 Enable -Wnull-dereference by default 2022-04-19 10:08:54 +02:00
Rene Kita
e8a41ecfcc Exit if we cannot allocate a new tab during start 2022-04-19 10:08:54 +02:00
Rene Kita
e6998fc9a4 Fix potential null dereference 2022-04-19 10:08:54 +02:00
Rene Kita
80642d1fe7 Fix potential null dereference 2022-04-19 10:08:54 +02:00
Rene Kita
a0b3c1b467 Fix potential null dereference 2022-04-19 10:08:54 +02:00
Rene Kita
9eaf044c02 Check return value of Str... functions 
All these functions, StrmyUFgets, StrISgets, etc. can potentially return
NULL. Add a check for it.
 2022-04-19 10:08:54 +02:00
Rene Kita
d33a522936 Fix potential null pointer dereference 2022-04-19 10:08:54 +02:00
Rene Kita
1308f5efe5 Check for NULL before dereferencing the pointer 
In case of an error the whole frame is freed, break out of the loop to
return early.
 2022-04-19 10:08:54 +02:00
Rene Kita
9f5c311e45 Do not call fclose() on a NULL pointer 
The if clause is true if cache is NULL. man 3 fclose says:

  The  behaviour  of  fclose() is undefined if the stream parameter is an
  illegal pointer, or is a descriptor already passed to a previous  invo‐
  cation of fclose().

Check if cache is NULL before calling fclose().
 2022-04-19 10:08:54 +02:00
Rene Kita
1365cc1ecc Check for NULL before dereferencing a pointer 
l is part of the exit condition of the while loop. If we exit the loop
because l is NULL, we cannot dereference it.
 2022-04-19 10:08:54 +02:00
Rene Kita
6432709b80 Check for NULL before dereferencing a pointer 
get_auth_param() returns NULL in case of error.
 2022-04-19 10:08:54 +02:00
Rene Kita
22d1fb47ac Remove null pointer dereference 
This if is only true if both strchr return NULL, making sure that *q is
a NULL dereference.

The intention was to remove trailing '>' (or '\t') from the message-id
(p) for add_news_message().

Adjust the condition.
 2022-04-19 10:03:13 +02:00
Rene Kita
beb07d24bc Fix a warning about an unused variable 
*xi is only used if USE_IMLIB is defined, move the declaration inside
the #ifdef block.
 2022-04-18 11:42:05 +02:00
Rene Kita
6d1a8d44e2 Cast away a warning 
strlen() takes a char *, but p is a unsigned char *.
 2022-04-18 11:42:05 +02:00
Rene Kita
9a2b86088c Fix broken anchor with link number at EOL 
If, while adding the link number, we detect that we need to flush the
line, the anchor will be broken. When returning to the last breakpoint
only the link number will be removed, the internal anchor reference '<a
hseq=... >' remains on the flushed line.

Instead of adding the link number in a separate operation, check if we
just processed an anchor tag and prepend the current token with the link
number.
 2022-04-17 16:04:41 +02:00
Tatsuya Kinoshita
fa6da6a0fa Update ChangeLog 2022-04-15 21:20:11 +09:00
Tatsuya Kinoshita
238b77f0fa Allow building without terminal library 
This reverts commit 0d3416e0c2.
cf. https://github.com/tats/w3m/pull/221
Bug-Chromium: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46629
 2022-04-15 21:07:40 +09:00
Tatsuya Kinoshita
6338651e22 Allow building without Perl 
This reverts commit a0c8de3f3f.
cf. https://github.com/tats/w3m/pull/221
 2022-04-15 21:07:30 +09:00
Tatsuya Kinoshita
15c77e3687 Do not reject FreeBSD framebuffer 
This reverts commit cb3118b389.
cf. https://github.com/tats/w3m/pull/221
 2022-04-15 21:07:02 +09:00
Tatsuya Kinoshita
006871f44c Update ChangeLog 2022-04-10 11:47:54 +09:00
Tatsuya Kinoshita
020f626a95 Remove unused encodeB declaration 2022-04-10 10:07:27 +09:00
Tatsuya Kinoshita
13dea10910 Remove unused MAX_WIDTH 2022-04-10 10:07:04 +09:00
Tatsuya Kinoshita
79dc67566a Prefer https for GNU URLs 2022-04-10 10:06:33 +09:00
Tatsuya Kinoshita
eb7ebb48ed Update ChangeLog 2022-04-09 19:38:24 +09:00
Tatsuya Kinoshita
ca9f5fc096 Merge pull request #222 from rkta/Wall 
Fix all reported warnings when -Wall is enabled and enable -Wall by default. While there, move OPTS to end of CFLAGS. This allows the user to override default options.
 2022-04-09 19:32:49 +09:00
Tatsuya Kinoshita
fecbe424c2 Update ChangeLog 2022-04-08 20:53:12 +09:00
Tatsuya Kinoshita
9d7d98c237 Merge pull request #221 from rkta/configure 
Add some missing checks to configure.
 2022-04-08 20:44:46 +09:00
Tatsuya Kinoshita
f80ccd42a6 Merge pull request #220 from rkta/posubst 
Do not swallow errors from GCC
 2022-04-08 20:40:07 +09:00
Tatsuya Kinoshita
ba3b7547a0 Update ChangeLog 2022-04-06 20:09:22 +09:00
Tatsuya Kinoshita
7ed4f7796c Adjust spacing in menu strings 
cf. https://github.com/tats/w3m/issues/225
 2022-04-06 20:08:00 +09:00
Tatsuya Kinoshita
79e8f2d608 Fix typo in menu strings 2022-04-06 20:07:39 +09:00
Tatsuya Kinoshita
f323f98b1a Update ChangeLog 2022-04-05 22:42:02 +09:00
Tatsuya Kinoshita
93b6fce6ca Merge branch 'bug/po-de' 2022-04-05 22:34:35 +09:00
Markus Hiereth
9e930f88d9 Updated German message catalogue 2022-04-05 22:30:29 +09:00
Tatsuya Kinoshita
9a8b0b11b7 Merge pull request #209 from sebras/master 
Add Swedish translation.
 2022-04-05 22:21:45 +09:00
Rene Kita
97af1e481f Do not swallow errors from GCC 
Without this patch posubst always exits with 0. This is a problem when
chaining commands.
 2022-02-20 11:25:15 +01:00
Rene Kita
d5817a26c7 Use strict and warnings in posubst 2022-02-20 11:25:15 +01:00
Rene Kita
cb3118b389 Check for linux/fb.h when configuring 2022-02-20 11:17:27 +01:00
Rene Kita
a0c8de3f3f Let configure fail if Perl is not in $PATH 2022-02-20 11:17:27 +01:00
Rene Kita
0d3416e0c2 Let configure fail if no terminal library is found 2022-02-20 11:17:26 +01:00
Rene Kita
72177529d2 Ignore autom4te cache directory 2022-02-20 11:17:26 +01:00
Rene Kita
5b33d9f239 Cast away a warning under OpenBSD 7.0 2022-02-20 11:14:54 +01:00
Rene Kita
bf40283a80 Enable -Wall by default 2022-02-20 11:14:54 +01:00
Rene Kita
0073ec6daf Use unsigned int for image size 
This removes a warning with -Wall.
 2022-02-20 11:14:54 +01:00
Rene Kita
cf2fd623fc Use cast to suppress warning 2022-02-20 11:14:54 +01:00
Rene Kita
d3ea4b33f1 Initialize struct before use 2022-02-20 11:14:54 +01:00
Rene Kita
c5c63a1a3d Fix a potential buffer overflow 
When compiling with -Wformat-overflow=2 GCC reports:
  note: 'sprintf' output between 16 and 35 bytes into a destination of size 32
 2022-02-20 11:14:54 +01:00
Rene Kita
cf7058b56c Let base64_encode() take a char * 
Throughout the whole code base only char * is passed, but a unsigned
char * is expected. This leads to several warnings.

Fix the interface and cast to unsigned char * internally to avoid any
changes to the behaviour.
 2022-02-20 11:14:54 +01:00