storm/w3m
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check return value of Str... functions

Browse Source 
All these functions, StrmyUFgets, StrISgets, etc. can potentially return
NULL. Add a check for it.
This commit is contained in:
Rene Kita
2022-04-15 12:42:24 +02:00
parent d33a522936
commit 9eaf044c02
4 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
news.c
View File

@@ -51,7 +51,7 @@ news_command(News * news, char *cmd, char *arg, int *status)
return NULL;
*status = -1;
tmp = StrISgets(news->rf);
if (tmp->length)
if (tmp && tmp->length)
sscanf(tmp->ptr, "%d", status);
return tmp;
}
@@ -396,7 +396,8 @@ loadNewsgroup0(ParsedURL *pu)
if (status == 224) {
f.scheme = SCM_NEWS;
while (1) {
tmp = StrISgets(current_news.rf);
if (!(tmp = StrISgets(current_news.rf)))
break;
if (NEWS_ENDLINE(tmp->ptr))
break;
if (sscanf(tmp->ptr, "%d", &i) != 1)
@@ -474,7 +475,8 @@ loadNewsgroup0(ParsedURL *pu)
if (status != 215)
goto news_end;
while (1) {
tmp = StrISgets(current_news.rf);
if (!(tmp = StrISgets(current_news.rf)))
break;
if (NEWS_ENDLINE(tmp->ptr))
break;
if (flag < 2) {