form.c: do not gratuitously turn GET into POST

When encountering a <form ...> tag that contains these values:

    method="get" enctype="multipart/form-data"

Do not transform the method into POST to accomodate enctype.

Instead behave in the compatible way that all other browsers
behave in this instance and ignore the enctype parameter
(treating it as the default application/x-www-form-urlencoded)
and perform a "GET" just as the method parameter requests.

This behavior produces far more compatible results than
gratuitously changing the "get" into a "post" which can
result in unexpected "405 Method Not Allowed" errors.

Signed-off-by: Kyle J. McKay <mackyle@gmail.com>
This commit is contained in:
Kyle J. McKay
2017-08-23 13:14:23 -07:00
parent d398b40332
commit 89e60cc474

5
form.c
View File

@@ -56,10 +56,9 @@ newFormList(char *action, char *method, char *charset, char *enctype,
m = FORM_METHOD_INTERNAL;
/* unknown method is regarded as 'get' */
if (enctype != NULL && !strcasecmp(enctype, "multipart/form-data")) {
if (m != FORM_METHOD_GET && enctype != NULL &&
!strcasecmp(enctype, "multipart/form-data")) {
e = FORM_ENCTYPE_MULTIPART;
if (m == FORM_METHOD_GET)
m = FORM_METHOD_POST;
}
#ifdef USE_M17N