From de57748043b7aeb9a6a949c5717d616b94d28bb2 Mon Sep 17 00:00:00 2001 From: Juliusz Chroboczek Date: Wed, 11 Jan 2023 19:36:33 +0100 Subject: [PATCH] Disable simulcast for screen sharing. Simulcast doesn't seem to work well with screen sharing: only one layer is sent, which has very low throughput since we send the low layer first. Disable simulcast for screen sharing. --- static/galene.html | 5 ++--- static/galene.js | 5 +---- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/static/galene.html b/static/galene.html index ef7408d..a5d464e 100644 --- a/static/galene.html +++ b/static/galene.html @@ -230,9 +230,8 @@ diff --git a/static/galene.js b/static/galene.js index 81c1c4a..a870284 100644 --- a/static/galene.js +++ b/static/galene.js @@ -607,9 +607,6 @@ function mapRequest(what) { case 'audio': return {'': ['audio']}; break; - case 'screenshare-low': - return {screenshare: ['audio','video-low'], '': ['audio']}; - break; case 'screenshare': return {screenshare: ['audio','video'], '': ['audio']}; break; @@ -1227,7 +1224,7 @@ function setUpStream(c, stream) { let bps = getMaxVideoThroughput(); // Firefox doesn't like us setting the RID if we're not // simulcasting. - if(simulcast) { + if(simulcast && c.label !== 'screenshare') { encodings.push({ rid: 'h', maxBitrate: bps || unlimitedRate,