From 4ad7c2f3030fbc27c292f70a474f2fd5dff19412 Mon Sep 17 00:00:00 2001
From: Juliusz Chroboczek <jch@irif.fr>
Date: Fri, 12 Apr 2024 00:47:51 +0200
Subject: [PATCH] Improve TestUpgradeDescription.

---
 group/description_test.go | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/group/description_test.go b/group/description_test.go
index 6be9473..45ab770 100644
--- a/group/description_test.go
+++ b/group/description_test.go
@@ -96,6 +96,22 @@ func TestUpgradeDescription(t *testing.T) {
 			t.Errorf("%v not equal: %v != %v", k, v1, v2)
 		}
 	}
+
+	if len(d1.FallbackUsers) != len(d2.FallbackUsers) {
+		t.Errorf("length not equal: %v != %v",
+			len(d1.FallbackUsers), len(d2.FallbackUsers))
+	}
+
+	for k, v1 := range d1.FallbackUsers {
+		v2 := d2.FallbackUsers[k]
+		if !reflect.DeepEqual(v1.Password, v2.Password) ||
+			!permissionsEqual(
+				v1.Permissions.Permissions(&d1),
+				v2.Permissions.Permissions(&d2),
+			) {
+			t.Errorf("%v not equal: %v != %v", k, v1, v2)
+		}
+	}
 }
 
 func TestNonWritableGroups(t *testing.T) {
@@ -109,7 +125,7 @@ func TestNonWritableGroups(t *testing.T) {
 
 	err = UpdateDescription("test", "", &Description{})
 	if !errors.Is(err, ErrDescriptionsNotWritable) {
-		t.Errorf("UpdateDescription: got %#v, " +
+		t.Errorf("UpdateDescription: got %#v, "+
 			"expected ErrDescriptionsNotWritable", err)
 	}
 }
@@ -202,7 +218,7 @@ func TestWritableGroups(t *testing.T) {
 
 	err = SetUserPassword("test", "jch", Password{
 		Type: "",
-		Key: "pw",
+		Key:  "pw",
 	})
 	if err != nil {
 		t.Errorf("SetUserPassword: got %v", err)