storm/skald
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Protect against tracks without a stream.

Browse Source
This commit is contained in:
Juliusz Chroboczek
2021-09-16 17:17:36 +02:00
parent e81ee4af5e
commit 09c5ba0d06
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rtpconn/webclient.go
+1 -1
View File
@@ -368,7 +368,7 @@ func addDownTrackUnlocked(conn *rtpDownConnection, remoteTrack *rtpUpTrack) erro
id = remoteTrack.track.Kind().String() id = remoteTrack.track.Kind().String()
} }
msid := remoteTrack.track.StreamID() msid := remoteTrack.track.StreamID()
if msid == "" { if msid == "" || msid == "-" {
log.Println("Got track with empty msid") log.Println("Got track with empty msid")
msid = remoteTrack.conn.Label() msid = remoteTrack.conn.Label()
} }
static/protocol.js
+4
View File
@@ -677,6 +677,10 @@ ServerConnection.prototype.gotOffer = async function(id, label, source, username
}; };
c.pc.ontrack = function(e) { c.pc.ontrack = function(e) {
if(e.streams.length < 1) {
console.error("Got track with no stream");
return;
}
c.stream = e.streams[0]; c.stream = e.streams[0];
let changed = recomputeUserStreams(sc, source, c); let changed = recomputeUserStreams(sc, source, c);
if(c.ondowntrack) { if(c.ondowntrack) {