da7d868c4b
build: Fix up some conditional code
...
Avahi and Ogg/Vorbis library conditional enablement wasn't working as
intended.
2017-05-01 15:04:44 -07:00
0da13b33f0
flac: Fix fd leak on bad FLAC files.
...
Some types of bad FLAC files error out early in the metadata parsing phase,
and we weren't properly deleting the iterator if it errored out at that
point.
2015-09-10 11:58:16 -07:00
916546d45f
tagutils: Fix divide-by-zero on bad FLAC files
2015-09-08 14:46:24 -07:00
30562d0b66
upnpttp: Implement PixelShape support.
...
TiVo uses this to get the aspect ratio correct on images.
2015-07-29 23:23:55 -07:00
9c5d8c7fd2
Fix memory leak with multi-picture FLAC files.
...
On my music archive, minidlnad wasn't anywhere near through scanning,
and had already leaked in excess of 10GiB from this.
The basic problem is that song_metadata has one image pointer. When it
sees a picture metadata item, it mallocs some space and copies the
picture to that, then sets the image pointer. That's all well and good,
except FLAC (and some other formats, haven't checked them) allow more
than one picture. So on the second picture, it does the same
thing—except overwriting the previous pointer, thus leaking it.
Simple fix: check if != NULL, ignore picture.
Signed-off-by: Justin Maggard <jmaggard@netgear.com >
2015-07-14 23:11:07 -07:00
24fb139678
metadata: Use "Album Artist" tag from AAC files.
...
Add Album Artist AAC metadata parsing contributed by SF user knono549.
Then, change music metadata gathering code to use either Album Artist
or Band as upnp:artist.
2015-02-03 17:22:32 -08:00
255bb2a5c4
tagutils-aac: fix bad null termination
...
SF bug #244 , patch #119
2014-07-11 17:20:41 -07:00
34cb08928c
portability: add support for Illumos
...
This still won't work on older Solaris systems, but modern Illumos
at least should build and run now.
2014-05-14 17:53:25 -07:00
13e3613dd6
Minor code simplification.
2014-04-28 12:00:59 -07:00
3a57744735
Add printf attribute to log_err/DPRINTF and fix a few warnings
...
Modified to not use %z for portability reasons.
2014-04-10 18:57:30 -07:00
bc43d45964
Clean up a couple return value checks.
2014-04-07 14:20:50 -07:00
d492b43ef8
Fix various potential illegal access and memory leaks in error conditions.
2014-04-07 11:20:19 -07:00
10471aa29b
portability: fix compiling on systems without iconv
2014-03-07 13:20:26 -08:00
a606012d23
Fix Clang compiler warnings.
2014-03-07 12:42:40 -08:00
b9404d1847
cleanup: remove unused tagutils code, and switch to standard int types
2014-03-06 17:08:21 -08:00
582dd80f3b
Add "albumartist" tag support for vorbis (flac). (Thanks SF user shimikano)
2014-02-03 11:47:16 -08:00
2c33d4149d
build: fix out of src tree builds
...
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk >
2014-01-31 15:33:51 -08:00
6f7b5761c6
Fix memory leak in AAC tag parsing.
2014-01-16 17:09:51 -08:00
035fd35ffd
* Fix up bad accesses found by valgrind.
2012-11-06 08:24:37 +00:00
2e120e83a0
* Add some logging and forking tweaks to work better with systemd.
2012-10-04 21:04:36 +00:00
5632e760f5
* Fix a possible file descriptor leak.
2012-06-26 18:23:04 +00:00
40f3664390
* Fix warn_unused_result compiler warnings with FORTIFY_SOURCE defined.
2012-03-28 08:15:15 +00:00
cabbd0b1de
* Use an asprintf wrapper, to report errors and NULLify the result.
2012-03-14 17:57:21 +00:00
c9d979886b
* Handle some (apparently) common WAV file malformations.
2012-03-14 08:38:59 +00:00
25c74a3962
* Fix a crash bug on some oddly-formed WAV files.
2012-03-08 18:11:01 +00:00
0a0be0d96c
* Add a MAXDEBUG log level.
2012-03-08 18:09:55 +00:00
62da09d9ce
* Consolidate playlist scanning functions, and fix bug where an empty line in a playlist would cause it get thrown out as invalid. (Thanks Sean Mahnken)
2011-11-05 00:37:08 +00:00
6b3729a147
* Support MP3 coverart extraction from certain podcasts that use an improper MIME type. (Thanks SF user jombatz)
2011-11-02 07:17:31 +00:00
773e1f6566
* Add support for other operating systems (kFreeBSD, FreeBSD, and OSX for now).
...
* Switch to autoconf from genconfig.sh.
2011-09-16 23:39:58 +00:00
63869c9e17
* Fix an invalid read if the last RIFF tag is an integer value.
2011-09-01 01:16:22 +00:00
88b253968f
* Fix compiling issues with some ffmpeg/libav versions.
2011-07-13 18:47:57 +00:00
741d4f7e99
* Fix up some minor quibbles from cppcheck.
2011-07-01 18:18:33 +00:00
1d7a890d09
* Do a case-insensitive search for "itrk" WAV metadata.
2011-06-27 23:27:09 +00:00
9347abcba0
* Handle a couple additional RIFF tags.
2011-06-22 00:20:19 +00:00
68bed133cd
* Add WAV file tag reading support.
2011-06-21 01:57:45 +00:00
5782be8ab2
* Improve WMA DLNA profile parsing.
2011-05-17 00:25:03 +00:00
9a9270cecf
* Fix some issues reported by cppcheck.
2011-05-02 23:50:52 +00:00
5c7cf70e02
* Fix a compiler warning when making 64-bit binaries.
2011-04-21 08:05:38 +00:00
87e71c443a
* Reorder a couple artist roles, to be more similar to the familar WMP organisation.
2011-02-15 01:03:15 +00:00
adeae41293
* Fix "dereferencing type-punned pointer will break strict-aliasing rules" compiler warning.
2011-02-15 00:02:13 +00:00
8e0fcd56f9
* Complete/clarify license information.
2010-11-11 23:48:14 +00:00
2f53a05727
* Fix typo.
2010-10-27 00:39:02 +00:00
acf6f16d02
* Fix big-endian issue with XING header parsing.
2010-09-01 00:33:43 +00:00
ebf2585c17
* Need to include config.h to get the HAVE_ICONV_H definition for localization.
2010-07-13 20:10:49 +00:00
3934bf4448
* Fix issue with playlists containing a single quote.
...
* Ignore bad playlists containing binary data.
2010-02-22 22:22:03 +00:00
c441187d2a
* Fix a couple potential buffer overflows.
2010-01-28 20:26:38 +00:00
346ff6e293
* Add M3U/PLS music playlist support.
2010-01-13 21:15:26 +00:00
41f204029b
* Fix some issues with uClibc.
2009-10-28 07:44:45 +00:00
ecec767f17
* Add PCM support, assuming defaults of 44.1K and 2 channels.
2009-10-12 21:07:14 +00:00
ba29e35bcc
* Clean up after some memory allocations before exit so valgrind is happy.
...
* Fork off the scanner process instead of doing it in another thread, so if libavformat leaks memory it will be cleaned up once scanning is finished.
2009-10-03 02:08:59 +00:00
Justin Maggard
Anthony DeRobertis
Justin Maggard
Catalin Patulea
Spencer Oliver