storm/minidlna
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

upnphttp: Kill strange HTTP request parsing

Browse Source 
Avoid reading uninitialized memory on malicious HTTP requests.

Fixes: Bug #293 - upnphttp.c ProcessHttpQuery_upnphttp() Function HTTP Request Handling Remote DoS
This commit is contained in:
Justin Maggard 2016-09-28 18:44:58 -07:00
parent da91cb8de2
commit 8a996b4b62
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
upnphttp.c
View File

@ -827,12 +827,6 @@ ProcessHttpQuery_upnphttp(struct upnphttp * h)
HttpCommand[i] = '\0'; HttpCommand[i] = '\0';
while(*p==' ') while(*p==' ')
p++; p++;
if(strncmp(p, "http://", 7) == 0)
{
p = p+7;
while(*p!='/')
p++;
}
for(i = 0; i<511 && *p && *p != ' ' && *p != '\r'; i++) for(i = 0; i<511 && *p && *p != ' ' && *p != '\r'; i++)
HttpUrl[i] = *(p++); HttpUrl[i] = *(p++);
HttpUrl[i] = '\0'; HttpUrl[i] = '\0';