storm/minidlna
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* Fix a couple potential memory leaks in album art error handling.

Browse Source
This commit is contained in:
Justin Maggard 2009-04-28 21:13:25 +00:00
parent c4ca6527f0
commit 7f01aa7080
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
albumart.c
View File

@ -148,22 +148,28 @@ check_embedded_art(const char * path, const char * image_data, int image_size)
{ {
asprintf(&art_path, DB_PATH "/art_cache%s", path); asprintf(&art_path, DB_PATH "/art_cache%s", path);
if( access(art_path, F_OK) == 0 ) if( access(art_path, F_OK) == 0 )
return art_path; goto end_art;
cache_dir = strdup(art_path); cache_dir = strdup(art_path);
make_dir(dirname(cache_dir), S_IRWXU|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH); make_dir(dirname(cache_dir), S_IRWXU|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH);
free(cache_dir); free(cache_dir);
dstfile = fopen(art_path, "w"); dstfile = fopen(art_path, "w");
if( !dstfile ) if( !dstfile )
return NULL; {
free(art_path);
art_path = NULL;
goto end_art;
}
nwritten = fwrite((void *)image_data, image_size, 1, dstfile); nwritten = fwrite((void *)image_data, image_size, 1, dstfile);
fclose(dstfile); fclose(dstfile);
if( nwritten != image_size ) if( nwritten != image_size )
{ {
remove(art_path); remove(art_path);
free(art_path); free(art_path);
return NULL; art_path = NULL;
goto end_art;
} }
} }
end_art:
image_free(imsrc); image_free(imsrc);
if( !art_path ) if( !art_path )
{ {