* Fix up error handling when given a bad order in SortCriteria.

This commit is contained in:
Justin Maggard 2012-04-07 16:47:13 +00:00
parent 755c81fd34
commit 58433d3fad

View File

@ -585,8 +585,7 @@ parse_sort_criteria(char *sortCriteria, int *error)
else else
{ {
DPRINTF(E_ERROR, L_HTTP, "No order specified [%s]\n", item); DPRINTF(E_ERROR, L_HTTP, "No order specified [%s]\n", item);
*error = -1; goto bad_direction;
goto unhandled_order;
} }
if( strcasecmp(item, "upnp:class") == 0 ) if( strcasecmp(item, "upnp:class") == 0 )
{ {
@ -612,6 +611,7 @@ parse_sort_criteria(char *sortCriteria, int *error)
else else
{ {
DPRINTF(E_ERROR, L_HTTP, "Unhandled SortCriteria [%s]\n", item); DPRINTF(E_ERROR, L_HTTP, "Unhandled SortCriteria [%s]\n", item);
bad_direction:
*error = -1; *error = -1;
if( i ) if( i )
{ {