storm/minidlna
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

metadata: Reduce stack usage in nfo parsing

Browse Source 
64KB is a bit much for a stack buffer.  Use dynamic allocation instead.
This commit is contained in:
Justin Maggard 2017-05-17 13:54:05 -07:00
parent 4f926639b2
commit 46c692fc59
2 changed files with 27 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
metadata.c
View File

@ -160,33 +160,40 @@ void
parse_nfo(const char *path, metadata_t *m)
{
FILE *nfo;
char buf[65536];
char *buf;
struct NameValueParserData xml;
struct stat file;
size_t nread;
char *val, *val2;
if( stat(path, &file) != 0 ||
file.st_size > 65536 )
if (stat(path, &file) != 0 ||
file.st_size > 65535)
{
DPRINTF(E_INFO, L_METADATA, "Not parsing very large .nfo file %s\n", path);
return;
}
DPRINTF(E_DEBUG, L_METADATA, "Parsing .nfo file: %s\n", path);
nfo = fopen(path, "r");
if( !nfo )
buf = calloc(1, file.st_size + 1);
if (buf)
return;
nfo = fopen(path, "r");
if (!nfo)
{
free(buf);
return;
}
nread = fread(&buf, 1, sizeof(buf), nfo);
fclose(nfo);
ParseNameValue(buf, nread, &xml, 0);
//printf("\ttype: %s\n", GetValueFromNameValueList(&xml, "rootElement"));
val = GetValueFromNameValueList(&xml, "title");
if( val )
if (val)
{
char *esc_tag, *title;
val2 = GetValueFromNameValueList(&xml, "episodetitle");
if( val2 )
if (val2)
xasprintf(&title, "%s - %s", val, val2);
else
title = strdup(val);
@ -197,39 +204,41 @@ parse_nfo(const char *path, metadata_t *m)
}
val = GetValueFromNameValueList(&xml, "plot");
if( val ) {
if (val)
{
char *esc_tag = unescape_tag(val, 1);
m->comment = escape_tag(esc_tag, 1);
free(esc_tag);
}
val = GetValueFromNameValueList(&xml, "capturedate");
if( val ) {
if (val)
{
char *esc_tag = unescape_tag(val, 1);
m->date = escape_tag(esc_tag, 1);
free(esc_tag);
}
val = GetValueFromNameValueList(&xml, "genre");
if( val )
if (val)
{
free(m->genre);
char *esc_tag = unescape_tag(val, 1);
free(m->genre);
m->genre = escape_tag(esc_tag, 1);
free(esc_tag);
}
val = GetValueFromNameValueList(&xml, "mime");
if( val )
if (val)
{
free(m->mime);
char *esc_tag = unescape_tag(val, 1);
free(m->mime);
m->mime = escape_tag(esc_tag, 1);
free(esc_tag);
}
ClearNameValueList(&xml);
fclose(nfo);
free(buf);
}
void