storm/minidlna
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

flac: Fix fd leak on bad FLAC files.

Browse Source 
Some types of bad FLAC files error out early in the metadata parsing phase,
and we weren't properly deleting the iterator if it errored out at that
point.
This commit is contained in:
Justin Maggard
2015-09-10 11:58:16 -07:00
parent e4dab2455b
commit 0da13b33f0
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tagutils/tagutils-flc.c
View File

@ -37,8 +37,9 @@ _get_flctags(char *filename, struct song_metadata *psong)
if(!FLAC__metadata_simple_iterator_init(iterator, filename, true, true))
{
DPRINTF(E_ERROR, L_SCANNER, "Cannot extract tag from %s\n", filename);
return -1;
DPRINTF(E_ERROR, L_SCANNER, "Cannot extract tag from %s [%s]\n", filename,
FLAC__Metadata_SimpleIteratorStatusString[FLAC__metadata_simple_iterator_status(iterator)]);
goto _exit;
}
do {