From 42a668753b04babb1e8e88ab3599ed65158e62b9 Mon Sep 17 00:00:00 2001 From: chrys Date: Mon, 4 Jun 2018 13:31:22 +0200 Subject: [PATCH] fix char review (last line was not navigateable) --- known bugs.txt | 7 +++---- src/fenrirscreenreader/utils/char_utils.py | 5 +++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/known bugs.txt b/known bugs.txt index e40965be..e22d0ddd 100644 --- a/known bugs.txt +++ b/known bugs.txt @@ -5,15 +5,14 @@ Known Bugs (Problems with the logic ): [] X is not being autodetected. (critical) [W] After switching back from X sometimes modifier keys are stuck. ( control or alt) (critical) [] PTY attribtues not all available at beginning just to current curser (normal) -[] review can run out of screen in PTY pressing next char (normal) -[W] Hilight Tracking not accurate (normal) -[W] make PTY better react to shortcuts when a lot of output apears (normal) [] Numlock/ Capslock is sometimes out of Sync (normal) [X] Bash history does not work with PTY (reads hole line) (normal) [X] space has different attributes on VCSA (normal) +[X] review can run out of screen in PTY pressing next char (normal) Glitches (improve diff results): -- currently None +[W] Hilight Tracking not accurate (normal) +[W] make PTY better react to shortcuts when a lot of output apears (normal) wishes: - whole status line in irssi is spoken insteed of just the changes (lilmike) diff --git a/src/fenrirscreenreader/utils/char_utils.py b/src/fenrirscreenreader/utils/char_utils.py index a41163c8..cf9d5f22 100644 --- a/src/fenrirscreenreader/utils/char_utils.py +++ b/src/fenrirscreenreader/utils/char_utils.py @@ -86,7 +86,7 @@ def getNextChar(currX,currY, currText): x = currX y = currY if x + 1 == len(wrappedLines[y]): - if y + 1 < len(wrappedLines) - 1: + if y + 1 <= len(wrappedLines) - 1: y += 1 x = 0 lineBreak = True @@ -97,7 +97,8 @@ def getNextChar(currX,currY, currText): x += 1 currChar = '' if not endOfScreen: - currChar = wrappedLines[y][x] + currChar = wrappedLines[y][x] + return x, y, currChar, endOfScreen, lineBreak def getPhonetic(currChar):